Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use notarized transcript instead of pre-fetched response for redaction #113

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

0xtsukino
Copy link
Collaborator

No description provided.

@heeckhau heeckhau linked an issue Oct 29, 2024 that may be closed by this pull request
@0xtsukino 0xtsukino marked this pull request as ready for review October 31, 2024 10:18
Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement thanks!

I've added some remarks and suggestions.

src/entries/Background/rpc.ts Show resolved Hide resolved
src/entries/Background/rpc.ts Show resolved Hide resolved
src/entries/Background/rpc.ts Outdated Show resolved Hide resolved
src/entries/Background/rpc.ts Show resolved Hide resolved
Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@0xtsukino 0xtsukino merged commit f3b8cc1 into main Nov 5, 2024
2 checks passed
@heeckhau heeckhau deleted the fix-redactions branch November 22, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Redaction Logic to Use Notarized Transcript
2 participants